Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Create the Associations Toolbar button to directly link to com_associations when editing a weblink #426

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

infograf768
Copy link
Contributor

Pull Request for Issue #419

Summary of Changes

As title says

Multilingual site. Edit weblink.

After patch

Associations Toolbar Button is present and correctly redirects to com_associations side by side view

Screen Shot 2020-08-02 at 12 10 40

Screen Shot 2020-08-02 at 12 11 39

Create the Associations Toolbar button to directly link to com_associations when editing a weblink
@wilsonge
Copy link
Contributor

wilsonge commented Aug 9, 2020

How does this work in joomla 3.6/3.7 where the component doesn’t exist? Is the isEnabled check good enough?

@infograf768
Copy link
Contributor Author

I guess it is enough indeed

@joomdonation
Copy link
Contributor

We implemented this change in the version for Joomla 4, so It would be nice to have it merged for Joomla 3. However, I will only merge it if maintainers agree that new version of weblinks will only support 3.9 and 3.10. We do not have resources to test it with 3.6 - 3.8 anymore .

@joomdonation joomdonation merged commit fc42670 into joomla-extensions:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants